Adds v2 test lab triggers #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronDev
reviewed
Sep 29, 2022
| handler?: (event: CloudEvent<TestMatrixCompletedData>) => any | Promise<any> | ||
| ): CloudFunction<CloudEvent<TestMatrixCompletedData>> { | ||
| if (typeof optsOrHandler === "function") { | ||
| handler = optsOrHandler as (event: CloudEvent<TestMatrixCompletedData>) => any | Promise<any>; |
There was a problem hiding this comment.
Any chance we can change this to not be any | Promise ? (same with others)
There was a problem hiding this comment.
Do you have a better recommendation?
We might be able to get away with void | Promise, but I'd argue it's better to be consistent with the other v2 event providers that all use any | Promise. For example remote config, storage, crashlytics, etc.
Also, we'd probably have to have a followup api review since this has already been approved by council
There was a problem hiding this comment.
I guess my main question was along the lines of if we could avoid the any.
But if theres prior art, and would require api review again... I'm alright leave it as-is.
taeold
approved these changes
Sep 29, 2022
TheIronDev
reviewed
Sep 29, 2022
|
I love all the thoroough documentation!!! |
TheIronDev
approved these changes
Sep 29, 2022
colerogers
force-pushed
the
colerogers.test-lab
branch
from
bd8947e to
4a1e23d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds test lab triggers to the v2 codebase and sneaks in some remote config changes. For remote config, we update the tsdoc strings for reference docs and remove @Alpha tags since the public docs have been published.
Test Lab functions: